Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use S3 classes and methods dispatch system instead of custom type checking #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use S3 classes and methods dispatch system instead of custom type checking #110

wants to merge 1 commit into from

Conversation

vh-d
Copy link

@vh-d vh-d commented Jan 18, 2020

Possible fix to #109

I realize the new code is a little bit more verbose but I hope it makes cleaner as well.

Note that we can skip structable and data.table classes when making new methods thanks to inheritance (structable inherits from ftable and data.table from data.frame).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vh-d